-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove git HEAD marks left in Kafka binding README.md #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
/rtm |
@lbroudoux @dalelane would you please look into this? It's a simple editorial change fixing remnants of the merge |
Thanks for the heads-up. We agreed with @dalelane in the previous #182 comment to fix this one when updating bindings for v3. Thus, the fix is integrated within #221 I think we can cancel this one as changes in #221 are larger. |
@lbroudoux I believe we should merge this asap. #221 is still under discussion regarding branch strategy, etc. cc @dalelane |
Going to review and merge it following the hold on discussions on #221 in #182 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR fixes a wrong git merge that happened in kafka/README.md file in #143 (comment)
Related issue(s)
#143 (comment)
cc @char0n